Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1023211: Support resample with rule offset W, ME, YE with closed = left #2254

Merged
merged 9 commits into from
Sep 20, 2024
Merged

SNOW-1023211: Support resample with rule offset W, ME, YE with closed = left #2254

merged 9 commits into from
Sep 20, 2024

Conversation

sfc-gh-nkrishna
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna commented Sep 9, 2024 •
edited
Loading

SNOW-1023211

This PR adds support for resample by rule offset W, ME, YE with parameter closed = left.

Note: Snowpark pandas resample implementation uses the Snowflake SQL function TIME_SLICE which assumes the left hand side of the given interval is closed, meaning support using closed = right parameter is non-trivial.

@sfc-gh-nkrishna sfc-gh-nkrishna added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Sep 9, 2024
@sfc-gh-nkrishna sfc-gh-nkrishna force-pushed the nkrishna-SNOW-1023211-resample branch from 4b2cf5d to 2d5bc81 Compare September 17, 2024 17:17
@sfc-gh-nkrishna sfc-gh-nkrishna changed the title [DRAFT] SNOW-1023211: Support resample by rule offset month SNOW-1023211: Support resample by rule offset month Sep 19, 2024
@sfc-gh-nkrishna sfc-gh-nkrishna changed the title SNOW-1023211: Support resample by rule offset month SNOW-1023211: Support resample with rule offset W, ME, YE Sep 19, 2024
@sfc-gh-nkrishna
add support for week, ME, YE
debeba9 
Signed-off-by: Naren Krishna <[email protected]>
@sfc-gh-nkrishna sfc-gh-nkrishna changed the title SNOW-1023211: Support resample with rule offset W, ME, YE SNOW-1023211: Support resample with rule offset W, ME, YE with closed = left Sep 19, 2024
@sfc-gh-nkrishna
fix some comments
b60aea5 
Signed-off-by: Naren Krishna <[email protected]>
@sfc-gh-nkrishna sfc-gh-nkrishna marked this pull request as ready for review September 19, 2024 16:26
@sfc-gh-nkrishna sfc-gh-nkrishna requested a review from a team as a code owner September 19, 2024 16:26
@sfc-gh-nkrishna sfc-gh-nkrishna removed NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Sep 19, 2024
@sfc-gh-nkrishna
fix tests
77473c4 
Signed-off-by: Naren Krishna <[email protected]>
@sfc-gh-nkrishna
address comments
6950787 
Signed-off-by: Naren Krishna <[email protected]>
@sfc-gh-nkrishna
add comment
66dd0d5 
Signed-off-by: Naren Krishna <[email protected]>
sfc-gh-helmeleegy
sfc-gh-helmeleegy approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sfc-gh-nkrishna sfc-gh-nkrishna merged commit d2d3e97 into main Sep 20, 2024
34 of 35 checks passed
@sfc-gh-nkrishna sfc-gh-nkrishna deleted the nkrishna-SNOW-1023211-resample branch September 20, 2024 20:48
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-helmeleegy sfc-gh-helmeleegy sfc-gh-helmeleegy approved these changes

@sfc-gh-nkumar sfc-gh-nkumar sfc-gh-nkumar approved these changes

Assignees
No one assigned
Labels
snowpark-pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-nkrishna @sfc-gh-nkumar @sfc-gh-helmeleegy